Skip to content

chore: replace package build setup with tsdown - #3571

Open
jpzwarte wants to merge 41 commits into
mainfrom
maintenance/3182-replace-esbuild-with-tsdown
Open

chore: replace package build setup with tsdown#3571
jpzwarte wants to merge 41 commits into
mainfrom
maintenance/3182-replace-esbuild-with-tsdown

Conversation

@jpzwarte

@jpzwarte jpzwarte commented Aug 4, 2026

Copy link
Copy Markdown
Member

Closes #3182
Closes #3569

Replaces the esbuild package build with tsdown and upgrades the Angular wrappers to Angular 22.

Packaging

  • Output moves from the package root to dist/; the packages are now resolved entirely through exports. main, module and types are dropped — exports already points at the JavaScript, and TypeScript picks up the adjacent .d.ts from there.
  • exports and publishConfig.exports are generated by tsdown from its entry list — change the build config, not the exports map by hand.
  • Sources (including index.ts / register.ts) move into src/. Styles move from .scss to .css, imported with with { type: 'css' };

Angular

Angular 21 → 22, builders moved to @angular/build, ^22.0.0 added to the peer range alongside 19–21.

Fixes

  • sideEffects still listed register.js, which matches neither src/register.ts nor dist/register.js under the new layout. Bundlers were silently tree-shaking away every import '@sl-design-system/*/register.js', leaving the custom elements unregistered.
  • Declare dependencies that were missing from package.json across 18 packages, plus missing peers (@open-wc/scoped-elements, @lit/localize, lit).
  • Restore the format-date/format.js, grid/utils.js and locales/*.xlf subpath exports that the generated exports map had dropped.
  • Add isDevMode() (@sl-design-system/shared/dev-mode.js), replacing the /// <reference types="vite/client" /> in icon and combobox that leaked an empty *.css ambient module into every consumer's TypeScript program.
  • Migrate examples/lit to .css as well, and teach the website's esbuild config to handle with { type: 'css' }.

Copilot AI lite review requested due to automatic review settings August 4, 2026 06:40
@changeset-bot

changeset-bot Bot commented Aug 4, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 92e1bef

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 72 packages
Name Type
@sl-design-system/accordion Patch
@sl-design-system/announcer Patch
@sl-design-system/avatar Patch
@sl-design-system/badge Patch
@sl-design-system/breadcrumbs Patch
@sl-design-system/button Patch
@sl-design-system/button-bar Patch
@sl-design-system/calendar Patch
@sl-design-system/callout Patch
@sl-design-system/card Patch
@sl-design-system/checkbox Patch
@sl-design-system/combobox Patch
@sl-design-system/data-source Patch
@sl-design-system/date-field Patch
@sl-design-system/dialog Patch
@sl-design-system/drawer Patch
@sl-design-system/editor Patch
@sl-design-system/ellipsize-text Patch
@sl-design-system/emoji Patch
@sl-design-system/form Patch
@sl-design-system/format-date Patch
@sl-design-system/format-number Patch
@sl-design-system/grid Patch
@sl-design-system/icon Patch
@sl-design-system/infotip Patch
@sl-design-system/inline-message Patch
@sl-design-system/listbox Patch
@sl-design-system/locales Patch
@sl-design-system/menu Patch
@sl-design-system/message-dialog Patch
@sl-design-system/number-field Patch
@sl-design-system/paginator Patch
@sl-design-system/panel Patch
@sl-design-system/popover Patch
@sl-design-system/progress-bar Patch
@sl-design-system/radio-group Patch
@sl-design-system/scrollbar Patch
@sl-design-system/search-field Patch
@sl-design-system/select Patch
@sl-design-system/shared Minor
@sl-design-system/skeleton Patch
@sl-design-system/spinner Patch
@sl-design-system/switch Patch
@sl-design-system/tabs Patch
@sl-design-system/tag Patch
@sl-design-system/text-area Patch
@sl-design-system/text-field Patch
@sl-design-system/time-field Patch
@sl-design-system/toggle-button Patch
@sl-design-system/toggle-group Patch
@sl-design-system/tool-bar Patch
@sl-design-system/tooltip Patch
@sl-design-system/tree Patch
@sl-design-system/virtual-list Patch
@sl-design-system/angular Major
@sl-design-system/bingel-dc Patch
@sl-design-system/bingel-int Patch
@sl-design-system/clickedu Patch
@sl-design-system/editorial-suite Patch
@sl-design-system/itslearning Patch
@sl-design-system/kampus Patch
@sl-design-system/magister Patch
@sl-design-system/max Patch
@sl-design-system/my-digital-book Patch
@sl-design-system/myvanin Patch
@sl-design-system/neon Patch
@sl-design-system/sanoma-learning Patch
@sl-design-system/sanoma-pro Patch
@sl-design-system/sanoma-utbildning Patch
@sl-design-system/teacher-assistant Patch
@sl-design-system/teas Patch
@sl-design-system/tig Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Copilot AI review requested due to automatic review settings August 5, 2026 07:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Copilot AI review requested due to automatic review settings August 10, 2026 07:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Copilot AI review requested due to automatic review settings August 10, 2026 08:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Copilot AI review requested due to automatic review settings August 10, 2026 08:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Copilot AI review requested due to automatic review settings August 10, 2026 08:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Copilot AI review requested due to automatic review settings August 10, 2026 09:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Copilot AI review requested due to automatic review settings August 11, 2026 08:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Copilot AI review requested due to automatic review settings August 11, 2026 08:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Copilot AI review requested due to automatic review settings August 11, 2026 08:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Comment thread packages/components/accordion/tsconfig.json
Comment thread .changeset/full-feet-sink.md Outdated
Comment thread website/esbuild.config.js
Comment thread website/esbuild.config.js
Comment thread vitest.config.ts
Comment thread package.json
Copilot AI review requested due to automatic review settings August 11, 2026 13:25

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Copilot AI review requested due to automatic review settings August 11, 2026 13:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Copilot AI review requested due to automatic review settings August 11, 2026 13:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Angular] Upgrade to version 22 [Maintenance] Replace esbuild build scripts with tsdown

4 participants