No routing new setup with typography - #3568
Draft
Diaan wants to merge 71 commits into
Draft
Conversation
…adability and maintainability
- Updated `build-themes.js` to include handling for deprecated themes. - Introduced a new function to create file configurations for deprecated themes. - Adjusted the theme filtering logic to accommodate deprecated tokens. - Added a new workspace for `deprecated-tokens` with its own build scripts. - Created `.tokensstudio.json` for deprecated tokens configuration. - Updated `package.json` files to include scripts for importing deprecated tokens. - Modified the main `package.json` to include the new workspace and import script.
…eparate-deprecated-project
…recated-project' of https://github.com/sl-design-system/components into chore/2873-remove-routing-from-token-setup-separate-deprecated-project
…ting-from-token-setup-separate-deprecated-project
… removed redundant code blocks and optimized existing functions.
…ting-from-token-setup-separate-deprecated-project
- Created developing.css with typography settings for the "developing" user group, including font sizes, line heights, letter spacing, and variable spaces. - Created early.css with typography settings for the "early" user group, mirroring the structure of developing.css but with adjusted values for font sizes and spacing.
- Adjusted regex for CSS variable names to allow uppercase letters. - Modified border radius token matching to use the correct prefix and exclude certain variables. - Enhanced typography mapping to use camelCase properties for better consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new
typography.cssfile for theme packages, centralizing and standardizing typography styles across themes. It updates the build and export process to include this new file, adjusts Storybook configuration to better support typography testing and theming, and makes related improvements to the workflow and theme loading logic.Theme system improvements:
typography.cssfile to each theme package (e.g.,packages/themes/core/typography.css) to define and centralize typography styles for headings, text, labels, captions, and more. This file is now included in the theme package exports and build outputs. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10].storybook/themes.tsand related build scripts to loadtheme.cssandglobal.cssonly, removing direct loading of typography or mode-specific CSS files. [1] [2]Storybook enhancements:
typography.stories.tsStorybook story to demonstrate and test all typography variants, including computed style inspection and font feature controls.Workflow and build process updates:
onlyChanged: false.global.cssfor improved color mode support.These changes improve the maintainability and consistency of typography across themes, make it easier to test typography in Storybook, and ensure that theme packages are correctly exporting all necessary style files.