Skip to content

No routing new setup - #3554

Draft
Diaan wants to merge 3 commits into
chore/2873-remove-routing-from-token-setup-separate-deprecated-projectfrom
no-routing-new-setup
Draft

No routing new setup#3554
Diaan wants to merge 3 commits into
chore/2873-remove-routing-from-token-setup-separate-deprecated-projectfrom
no-routing-new-setup

Conversation

@Diaan

@Diaan Diaan commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

- Deleted unused token files for device typography, scale, space, and typography.
- Updated the theme setup script to reflect changes in source theme files and improved logging for theme generation.
- Adjusted the studio.lock file to reflect new source references and updated timestamps.
Copilot AI review requested due to automatic review settings July 27, 2026 07:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of lines (20,000). Try reducing the number of changed lines and requesting a review from Copilot again.

@Diaan
Diaan changed the base branch from main to chore/2873-remove-routing-from-token-setup-separate-deprecated-project July 27, 2026 07:54
@Diaan Diaan self-assigned this Jul 27, 2026
Diaan added 2 commits July 27, 2026 13:33
…oken-setup-separate-deprecated-project' into no-routing-new-setup
…iles to ensure proper formatting; modify setup-themes script for improved theme handling; update package.json to streamline token import process; refresh studio.lock with new generated timestamps and integrity hashes.
Copilot AI review requested due to automatic review settings July 27, 2026 14:35
@changeset-bot

changeset-bot Bot commented Jul 27, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: f8f2078

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 41 out of 195 changed files in this pull request and generated 5 comments.

Comment thread scripts/setup-themes.js
Comment on lines 12 to +15
const destinationTypography = join(cwd, `${theme}/typography.css`);

const typographyCssFiles = [
'./export/core-css/Device/tablet.css',
'./export/core-css/Device/desktop.css',
'./export/core-css/Device/mobile.css',
'./export/core-css/User-Group/advanced.css',
'./export/core-css/User-Group/early.css',
'./export/core-css/User-Group/developing.css',
'../packages/themes/core/typography.css'
const themeName = theme.split('/').pop();
const sourceThemeFiles = [
Comment thread scripts/setup-themes.js
Comment on lines +27 to +31
let content = data;
if (file.includes(`${themeName}.css`)) {
content = content.replace(new RegExp(`\\[data-brand="${themeName}"\\]`, 'g'), 'body');
}
resolve(content);
Comment thread .storybook/themes.ts
Comment on lines 180 to +184
let currentThemeId: string | undefined;
let currentMode: Mode | undefined;

export const updateTheme = async (themeId: string, mode: Mode = 'light'): Promise<void> => {
if (currentThemeId === themeId && currentMode === mode) {
export const updateTheme = async (themeId: string): Promise<void> => {
if (currentThemeId === themeId) {
Comment on lines +1 to +7
@media (prefers-color-scheme: dark) {
:root {
--color-scheme: dark;
color-scheme: dark;
}
}

Comment thread .storybook/preview.ts
Comment on lines +114 to +120
(story, { globals: { mode = 'light' } }) => {
//TODO if you remove these it takes the user preference from the system.
// document.documentElement.style.setProperty('--color-scheme', mode);
// document.documentElement.style.setProperty('color-scheme', mode);

return story();
},
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants