Cover the layouts reported broken against 1.x - #1017
Conversation
Three open issues describe layouts the View and balloon-compose implementations got wrong. The rewrite makes all three structural rather than incidental, but that is exactly the kind of claim that quietly stops being true, so each one gets a test before the issues are closed. - A height on the anchor's PARENT clamping the balloon (#952). The body is measured in a `Popup` against the window now, and `setHeight` maps to `requiredHeight`, so a 44dp parent no longer produces a 44dp balloon. - An anchor inside a `Dialog` (#918), which used to crash casting layout params and then showed nothing once it stopped crashing. The test asserts the body is really displayed, not just that `isVisible` flipped. - A full-bleed body against a large corner radius (#970). 1.x had `setIsClipArrowEnabled`, off by default, which is what let a custom `setLayout` paint square corners over a rounded background. The clip is unconditional here, and the new golden fills its corners in with the body colour if that ever changes.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. WalkthroughThe PR adds a golden test for full-bleed rounded content and Skia UI tests for balloon sizing and dialog anchoring. ChangesBalloon regression coverage
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change adds regression coverage for three reported layout issues without changing production behavior. No actionable merge-blocking risk remains after normal checks and review. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Description checkExplanation The description clearly states the goal, identifies issues ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Adds regression coverage for the three open issues that describe layout bugs in the 1.x implementations, so they can be closed against something verifiable rather than an assumption.
Dialog. Asserts the body is actually displayed, not just thatisVisibleflipped.content-full-bleed-large-radius, whose corners fill in with the body colour if the shape clip ever stops being unconditional.desktopTestis 159 tests, 0 failures.Summary by CodeRabbit