Add advanced mapping contracts for 1.2.0 - #26
Merged
Conversation
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'SourceGeneratorBenchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.25.
| Benchmark suite | Current: 91d6eb6 | Previous: a73afe7 | Ratio |
|---|---|---|---|
DomainMapper.Benchmarks.SourceGeneratorBenchmarks.DomainMapperColdGeneration |
647115.8317708333 ns (± 2849.4856639081804) |
424152.4607872596 ns (± 3926.4595598279025) |
1.53 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'ComparisonMappingBenchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.25.
| Benchmark suite | Current: 91d6eb6 | Previous: e53a7e8 | Ratio |
|---|---|---|---|
DomainMapper.Benchmarks.ComparisonMappingBenchmarks.MapperlyValueObjectFactory |
16.57613788980704 ns (± 0.9234156103640093) |
6.188103819886844 ns (± 0.13244699807809548) |
2.68 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Impact
DomainMapper 1.2.0 adds reusable opt-in advanced mapping contracts without assembly scanning, runtime reflection, persistence assumptions, or mutable runtime configuration. Convention-only consumers retain the existing direct generated-code path.
Validation
git diff --check