[MNT] remove extraneous material from package wheel - #588
Merged
Conversation
fkiraly
added
the
maintenance
There was a problem hiding this comment.
Pull request overview
This PR updates the setuptools package discovery configuration to ensure only the skbase Python packages are included in built wheels, preventing repository-root maintenance/developer folders from being accidentally shipped.
Changes:
- Switches
tool.setuptools.packages.findfrom an exclude-list to an explicit include-list (skbase/skbase.*) to future-proof wheel contents. - Updates
tool.setuptools.package-datato targetskbaseand narrows the listed data file patterns.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of sktime/sktime#10891
Explicitly excludes folders from repository root that should not be shipped with release package wheels:
build_tools(for maintainers only)docs(for developers with a clone only)examples(consumption via clone, binder/colab resp online docs only)Mechanism: changing to explicit include (also future-proof) as opposed to widening exclude statement, in
tool.setuptools.packages.find.