Skip to content

[MNT] Remove PyYAML and Cython CI workaround - #140

Draft
amotl wants to merge 2 commits into
ci-reduce-jobsfrom
ci-rm-cython-pyyaml
Draft

[MNT] Remove PyYAML and Cython CI workaround#140
amotl wants to merge 2 commits into
ci-reduce-jobsfrom
ci-rm-cython-pyyaml

Conversation

@amotl

@amotl amotl commented Sep 6, 2026

Copy link
Copy Markdown
Member

About

Reassess the legacy CI workaround that prebuilds PyYAML==5.4.1 with a Cython < 3.0 build constraint. PyCaret does not directly import PyYAML or Cython; PyYAML is only included through optional extras.

References

@amotl
amotl requested a review from WilliamJudge94 September 6, 2026 09:40
@amotl amotl linked an issue Sep 6, 2026 that may be closed by this pull request
@amotl
amotl marked this pull request as ready for review September 6, 2026 10:25
@fkiraly fkiraly added the maintenance Continuous integration, unit testing & package distribution label Sep 6, 2026

@fkiraly fkiraly left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you kindly explain why we can simply remove this?

Also, there are merge conflicts with main.

@amotl

amotl commented Sep 6, 2026

Copy link
Copy Markdown
Member Author

Can you kindly explain why we can simply remove this?

The patch is just probing if we could remove this snippet per CI outcome, and to gather responses from the community that say we shouldn't. Do you have any concerns about removing Cython because of performance regressions?

Also, there are merge conflicts with main.

The PR is stacked on another one and got out of sync. Please don't worry: I don't always keep all things in sync to save CI minutes, but will resolve conflicts before merging, when applicable.

@amotl
amotl requested a review from fkiraly September 6, 2026 12:33
@fkiraly

fkiraly commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Do you have any concerns about removing Cython because of performance regressions?

No, I simply do not have enough information of what the snippet does and what happens if we remove it, that´s all. I was asking for more info.

@amotl

amotl commented Sep 6, 2026

Copy link
Copy Markdown
Member Author

Let's toggle the patch into draft mode again and wait for @WilliamJudge94 to possibly come up with answers to those details later?

@amotl
amotl marked this pull request as draft September 6, 2026 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Continuous integration, unit testing & package distribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[MNT] Reassess the PyYAML and Cython CI workaround

2 participants