[MNT] Make "plotting" features optional - #130
Open
amotl wants to merge 13 commits into
Open
Conversation
amotl
force-pushed
the
plotting-optional
branch
3 times, most recently
from
September 5, 2026 11:04
2cc0162 to
b93b900
Compare
amotl
marked this pull request as ready for review
September 5, 2026 12:37
amotl
changed the title
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This comment was marked as duplicate.
This comment was marked as duplicate.
fkiraly
added
the
maintenance
fkiraly
reviewed
Sep 5, 2026
fkiraly
reviewed
Sep 5, 2026
fkiraly
reviewed
Sep 5, 2026
fkiraly
requested changes
Sep 5, 2026
fkiraly
left a comment
fkiraly
left a comment
Contributor
There was a problem hiding this comment.
Agree in-principle, smaller comments:
- should we call the extra
plots? - If we are already doing soft dependency isolation, I would do it with
scikit-base_check_soft_dependenciesto deduplicate. I think the authors ofpycaretcopied this_check_soft_dependenciesfrom an early version insktime, but did not fix some of the inconsistencies (such as whether the import name, or the pypi name is used)
amotl
force-pushed
the
plotting-optional
branch
2 times, most recently
from
September 5, 2026 21:29
8f20a38 to
732db7c
Compare
amotl
force-pushed
the
plotting-optional
branch
from
September 6, 2026 13:30
732db7c to
3ca6835
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About
Break out all packages concerned about plotting into a dedicated dependency group.
Goal
Reduce the number of baseline dependency packages.
Details
Extract relevant packages into the
plotspackage extra. Users choosing thefullextra will not notice any difference, because it includes theplotsextra from the start.