Convert application infrastructure to TypeScript - #68
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bring the remaining application infrastructure under strict TypeScript checking by converting ten modules: the player and Timbre adapters, MIDI helpers/export, Ace setup, sorting registry/source map, and worker entry. Keep the eight built-in algorithm implementations as JavaScript because their raw source is shown and edited as JavaScript.
Add typed settings getters and explicit player, frame, callback, and canvas contracts. Supply focused declarations for Timbre's browser API, Ace's browser subpath, and the installed jsmidgen API, whose File.toBytes returns a binary string. Remove the now-unnecessary string assertion at MIDI export. Update imports, documentation links, and the worker lint path. No dependencies added.
Validation:
pnpm run check: lint, formatting, spelling, strict type checking, 353 Vitest tests (including Chromium hook tests), and production build pass.git diff --checkpasses.The declarations describe the third-party API subset used by this application. Tests remain JavaScript. Audio synthesis and MIDI timing are preserved; no new listening comparison was performed.