Move playground state and effects into React and Jotai - #67
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move playground state and lifecycle coordination into React and Jotai. Components now consume the document-scoped Jotai Provider directly, and playground actions come from React context. Settings, custom algorithms, playback preferences, and visualization choice survive client-side navigation while Home's audio and worker resources are disposed.
Changes:
usePlayersanduseSort. React effects own audio setup, settings synchronization, sample preloading, worker cancellation, and edit debouncing.Validation:
pnpm run check: lint, formatting, spelling, TypeScript, 353 tests, and production build pass.pnpm test; both CI workflows install Chromium before checks. jsdom is not installed. Loop controls update their atom directly instead of passing through the action context.git diff --checkpasses.Audio synthesis and transport algorithms are unchanged. Automated checks exercise their integration; no new listening comparison was performed.