Fix accessibility failures and add lint and browser audits - #64
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the accessibility failures reported by Lighthouse: tab controls referenced missing panel IDs, and the footer icon repeated its adjacent link text. Let Base UI own panel IDs, use data attributes for test selectors, and give the decorative footer icon empty alt text. About and API now also provide a main landmark.
Enable Oxlint's jsx-a11y correctness rules, with documented exceptions for semantic-role preferences and keyboard-scrollable documentation tables. Shared link and label components expose forwarded content and associations explicitly. Add axe browser audits for all three pages, settings tabs, algorithm dialogs, and MIDI export dialogs, and document the workflow.
Validation:
pnpm run check: lint, formatting, spelling, types, 362 unit tests, and production build passed.git diff --checkpassed.The Lighthouse result covers automated checks on Home; manual keyboard and screen-reader review remains relevant.