Replace D3 DOM rendering with React SVG charts - #60
Merged
Merged
Conversation
Replace imperative D3 bar and trajectory renderers with React SVG components subscribed to player snapshots. Keep audio clocks outside React, preserve pointer capture editing and cancellation, and memoize trajectory geometry across playback updates. Render the envelope declaratively, remove the visualization stylesheet and d3-selection dependency, and retain D3 only for pure calculation helpers. Rename envelope utilities, type trajectory geometry and visualization modes, and add the required D3 type declarations. Update documentation and regression coverage for duplicate-value trajectories, finite geometry, hover styling, and cancelled pointer edits. Verified the full check pipeline with 362 unit tests and 38 browser tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move ownership of chart SVG children from D3 to React, with Tailwind styling and no intended redesign. Audio timing remains outside React.
Rendering and behavior
Structure and types
Verification