Composer: raise the minimum supported PHPCS/Utils versions - #378
Merged
Conversation
PHP_CodeSniffer released security versions the other week, so unless security advisories would be actively ignored, CI will fail on a failure to install for `lowest`. Along the same lines, PHPCSUtils released a security version a week before that. As it would be prudent to encourage users to upgrade anyhow, I'm proposing to raise the minimum supported PHPCS/Utils versions to get round the CI issue. Alternatively, it could be chosen to not raise the minimum version, but to ignore the security advisories in CI. As the difference between the "old" vs "new" versions for PHPCS is relatively small, I'm suggesting to just bump the versions. Includes updating the README and the GHA workflows to match. Refs: * https://github.com/PHPCSStandards/PHP_CodeSniffer/releases#release-3.13.6 * https://github.com/PHPCSStandards/PHP_CodeSniffer/releases#release-4.0.2 * https://github.com/PHPCSStandards/PHPCSUtils/releases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP_CodeSniffer released security versions the other week, so unless security advisories would be actively ignored, CI will fail on a failure to install for
lowest. Along the same lines, PHPCSUtils released a security version a week before that.As it would be prudent to encourage users to upgrade anyhow, I'm proposing to raise the minimum supported PHPCS/Utils versions to get round the CI issue. Alternatively, it could be chosen to not raise the minimum version, but to ignore the security advisories in CI. As the difference between the "old" vs "new" versions for PHPCS is relatively small, I'm suggesting to just bump the versions.
Includes updating the README and the GHA workflows to match.
Refs: