Conversation
Ensure AddHeatmapActor properly handles null actors by logging a warning and returning early; remove the commented UMobiusWidgetSubsystem dependency and its error UI path. Also remove an unused commented include in the .cpp and apply whitespace/formatting and comment clarifications in HeatmapSubsystem.h (including a clearer note about UpdateSpawnLocationAndHeatmapSize being called from the mesh-building flow).
sir306
added a commit
that referenced
this pull request
Jul 20, 2026
…roundwork (#3 WIP) #4 slider handle (Geometry/Display OpacitySlider): the slider baked the accent INTO its thumb brush tint AND also received the accent handle-colour multiplier, so the handle rendered accent^2 (a dark navy). The theme walker now neutralises slider thumb/bar brush tints to white so the handle/bar colour multipliers render cleanly (same class as the D169 border double-tint fix). Systemic; bars guarded to resource-less (leaves gradient / HSV-picker bars alone). #3 ribbon tab font on startup (PARTIAL / under investigation): startup theming now re-applies via a short self-cancelling ticker (widgets/tabs can construct seconds after launch behind shader compilation; the only prior startup trigger could miss them), ApplyToLiveWidgets returns a count so the ticker knows when the UI exists, and ribbon-tab labels are now themed regardless of a custom SWS text style. Verified the pass runs on startup and colours the ACTIVE tab, but INACTIVE tabs still render their white design-time label — remaining cause needs live tab-widget inspection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure AddHeatmapActor properly handles null actors by logging a warning and returning early; remove the commented UMobiusWidgetSubsystem dependency and its error UI path. Also remove an unused commented include in the .cpp and apply whitespace/formatting and comment clarifications in HeatmapSubsystem.h (including a clearer note about UpdateSpawnLocationAndHeatmapSize being called from the mesh-building flow).