Conversation
Fix an issue for xlsx files with absolute reference ids like "/xl/tables/table1.xml" instead of the Excel generated "../tables/table1.xml" Closes tafia#587
Fixed an issue where xlsx files with tables that have the insertRow attribute set returned a Dimensions object with the end row less than the start row. This caused an assert/panic when trying to create a Range object to return the table range. This issue was caused by an misinterpretation of the insertRow attribute to mean that table had one row less than the reported range. This is not the case. The insertRow attribute is used to report to consuming applications that the table has one empty row that is ready for data. See ECMA-376 Part1 Section 18.5.1.2 "table (Table)". Closes tafia#589
Add limits to prevent memory exhaustion from malicious ODS files that declare billions of repeated cells via table:number-rows-repeated and table:number-columns-repeated attributes. Protection layers: - Cap columns per row at MAX_COLUMNS (16,384) - Cap total row repeats at MAX_ROWS (1,048,576) - Cap total cells at MAX_CELLS (100 million) in get_range() These limits match XLSX's existing row/column limits and prevent a 7KB malicious file from attempting to allocate memory for 17+ billion cells. When MAX_CELLS is exceeded, return OdsError::CellLimitExceeded instead of silently returning an empty range. This ensures callers are properly informed of truncation rather than receiving silent data loss.
# Conflicts: # tests/test.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.