Skip to content

Error handling for cacheField tag #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
siqpush merged 1 commit into from
Nov 28, 2025
Merged

Error handling for cacheField tag #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 18 additions & 17 deletions src/xlsx/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2817,23 +2817,24 @@ fn get_pivot_cache_iter<'a, RS: Read + Seek + 'a>(
match xml.read_event_into(&mut buf) {
Ok(Event::Start(e)) if e.local_name().as_ref() == b"cacheField" => {
for a in e.attributes() {
if let Ok(Attribute {
key: QName(b"name"),
value,
}) = a
{
field_names.push(xml.decoder().decode(value.as_ref())?.to_string());
fields.push(vec![]);
}
// The formula property of cacheField represents a calculated field / item.
// This does not represent the underlying data and should be removed.
else if let Ok(Attribute {
key: QName(b"formula"),
value: _value,
}) = a
{
field_names.pop();
fields.pop();
match a? {
Attribute {
key: QName(b"name"),
value,
} => {
field_names.push(xml.decoder().decode(value.as_ref())?.to_string());
fields.push(vec![]);
}
Attribute {
key: QName(b"formula"),
value: _value,
} => {
field_names.pop();
fields.pop();
}
_ => {
// do nothing
}
}
}
}
Expand Down