docs: define story-number stability and source-tag examples for AC IDs#119
docs: define story-number stability and source-tag examples for AC IDs#119singyichen wants to merge 2 commits into
Conversation
- **Define** story numbers as identities, not positions: new stories take the next unused number and are never renumbered, so AC-<story>.<seq> IDs survive story insertion or priority-based reordering (Codex P2 finding on #117); spec-template bumped to v1.5.1 - **Sync** the spec-format skill's AC ID rule with the same story-number stability wording - **Show** the (Source: AC-N.N) tag on the acceptance-criteria skill's Core Behavior examples so generated standalone checklists demonstrate the traceability principle instead of only stating it (Codex P1 finding on #117) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
There was a problem hiding this comment.
Documentation improvements are correctly implemented. The changes successfully address the two Codex findings by adding traceability source tags to examples and establishing story-number stability rules. The wording is consistent across spec-template and spec-format skill, and the changelog properly documents version 1.5.1.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
There was a problem hiding this comment.
Code Review
This pull request updates the specification templates and skill guidelines to clarify that User Story numbers are stable identifiers rather than positional indicators, ensuring that story numbers and their associated Acceptance Criteria (AC) IDs remain unchanged when display order is adjusted. Additionally, source mappings were added to the functional acceptance criteria in the skill documentation, and the template changelog was updated to version 1.5.1. The feedback recommends a minor phrasing improvement in the template instructions to clarify 'AC ID 的故事段' as 'AC ID 中的故事編號部分' for better precision.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
- **Replace** the ambiguous shorthand "AC ID story segment" with "the story-number part of the AC ID" in the stability guidance comment, per Gemini's clarity finding; the spec-format skill wording was already unambiguous and needed no change Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- **Resolve** the spec-template changelog conflict by keeping both entries: 1.6.0 (this branch) above 1.5.1 (PR #119 story-number stability rule, merged to main after this branch was cut) - **Verify** PR #119's story-number stability additions auto-merged intact into the v1.6.0 AC comment block and the spec-format skill Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Purpose
Close the two remaining Codex findings on the AC stable-ID standard introduced in #117: story-number stability and demonstrated source tags.
Reason
Two Codex findings were posted on #117 after it merged:
(Source: AC-N.N)traceability tag the skill itself mandates, so generated checklists would likely omit it.AC-<story>.<seq>IDs embed the story number, but nothing forbade renumbering stories on insertion or priority reordering — which would silently break every published AC ID.Result
(Source: AC-1.1)/(Source: AC-1.2)/(Source: AC-1.3)Changed Files
.specify/templates/spec-template.md.claude/skills/spec-format/SKILL.md.claude/skills/acceptance-criteria/SKILL.md(Source: AC-N.N)tagsTest Plan
Impact Scope
Related
#117
🤖 Generated with Claude Code