feat(displays): add night light settings UI in displays - #20
Open
mateoalfaro wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a Night Light group to the Displays page, complementing the existing quick tile, which only toggles Night Light and already reflects the schedule-aware effective state.
Adds a master
SwitchRowbound tonight-light-enabledviasettings.bind(..., switch_btn, ...), following the existing codebase pattern.Adds an Adaptive Schedule switch that shows or hides the schedule controls.
Adds From and To
TimePickerrows that write through the manager setters.Adds a temperature
Gtk.Scalecovering 1000–6500 K in 100 K steps.Keeps controls synchronized with external changes, including:
Synchronization is handled through
NightLightManager.changed, withSignalHandler.block_matchedpreventing feedback loops.Updates the master row subtitle to reflect the effective state:
OnOffOff until 19:00when adaptive scheduling is enabledNo new dependencies are introduced. The implementation uses the existing
PreferencesGroup,SwitchRow, andTimePickerwidgets.Dependencies
Depends on the corresponding prs:
libsingularitychanges for the manager APIsingularity-desktopchanges for the settings schema