Skip to content

[BUGFIX] Fix RemoteAtomDB test constructors after API changes - #1274

Merged
marcocapozzoli merged 1 commit into
masterfrom
masc/bugfix_remote-atomdb-test
Sep 14, 2026
Merged

[BUGFIX] Fix RemoteAtomDB test constructors after API changes#1274
marcocapozzoli merged 1 commit into
masterfrom
masc/bugfix_remote-atomdb-test

Conversation

@marcocapozzoli

Copy link
Copy Markdown
Collaborator

This PR updates RemoteAtomDBFederationTest.PatternAssignmentsSurvivePeerAndFacadeAggregation
to use the current RemoteAtomDBPeer and RemoteAtomDB constructor signatures.

@marcocapozzoli marcocapozzoli self-assigned this Sep 14, 2026
@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Essentials

Run ID: 3ad7f0f6-506f-46fa-86cb-7d0b07c703ad

📥 Commits

Reviewing files that changed from the base of the PR and between bcc648c and a5a5edf.

📒 Files selected for processing (1)
  • src/tests/cpp/remote_atomdb_test.cc

Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


  • Updated PatternAssignmentsSurvivePeerAndFacadeAggregation to use the current RemoteAtomDBPeer constructor.
  • Updated RemoteAtomDB construction to pass the peer map and facade UID.
  • The change affects test setup only. It introduces no production behavior, thread-safety, error-handling, or hot-path allocation changes.
  • The existing federation test covers the affected aggregation behavior. No additional client tests are indicated.

Walkthrough

Changes

RemoteAtomDB test wiring

Layer / File(s) Summary
Update constructor arguments
src/tests/cpp/remote_atomdb_test.cc
The test now passes the peer UID to RemoteAtomDBPeer and the facade UID to RemoteAtomDB.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested reviewers: ccgsnet

Merge Risk: ⚪ Minimal · up to a5a5e

The change only updates test wiring to the current APIs; no concrete merge risk is identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the bug fix and the constructor updates in the RemoteAtomDB test. It matches the main change.
Description check ✅ Passed The description directly explains that the test now uses the current RemoteAtomDBPeer and RemoteAtomDB constructor signatures.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Tests For Behavior Changes ✅ Passed PASS. The authoritative diff contains one changed file: src/tests/cpp/remote_atomdb_test.cc. The patch only updates test construction calls to the current RemoteAtomDBPeer and RemoteAtomDB signa…
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch masc/bugfix_remote-atomdb-test

Comment @coderabbitai help to get the list of available commands.

@marcocapozzoli
marcocapozzoli merged commit 46000d1 into master Sep 14, 2026
3 checks passed
@marcocapozzoli
marcocapozzoli deleted the masc/bugfix_remote-atomdb-test branch September 14, 2026 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants