Show the finished sites on the landing page - #384
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/examplesshipped in #382 reachable only from the nav and the footer. The landing page is where people actually arrive, and it went straight from "here are the six pipeline steps" to "here are some abstract style swatches" without ever showing a finished site.This adds a section between them: the pipeline says how it works, this says what comes out of it. Three cards, real screenshots of the built bundles, each linking to the bundle itself rather than a preview.
Costs almost nothing
Measured on an emulated phone, cold cache, against production without the section:
2 KiB of JavaScript. The card art does not appear in either figure because it is
loading="lazy"and sits well below the fold, so it costs nothing until someone scrolls to it. The rest of the difference is the extra server-rendered markup.The manifest is read in
page.tsx, the server shell, and only{slug, name, tagline}is passed down — the same reason the preset catalogue is read there rather than imported by the client component. The palette notes stay on the server.Verified
Server-rendered markup contains all three links and the heading, checked with curl rather than by reading the JSX. Screenshotted at 1440 and 390 wide: cards sit three-up on desktop, stack on mobile, no horizontal overflow at either.
Suite 480 to 483. Two mutants: eager-loading the card art fails, and pointing the shell at a manifest that does not exist fails.
tsc --noEmitclean,eslintclean, production build clean.The section renders nothing at all if the manifest is missing or unreadable, rather than shipping an empty heading.