Repository navigation
improvement(org): move the People page onto the new design system - #9720
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
[Medium impact] The PR appears safe to merge; no actionable issues remain from this review. SummaryMoves People onto the shared design system, including the org chart, directory, profiles, imports, and directory sync.
Reviews (3) · Last reviewed commit: "fix(people): keep the publish refresh on..." · Reviewed by Greptile |
There was a problem hiding this comment.
All reported issues were addressed across 69 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 70 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
…he SCIM status read from load
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
?panel=syncURL, with a summary for each state: connected, first sync, syncing, publishing, waiting to retry, failed, pausedcanBrowsePeople, so a member withheld the directory gets a 404 from a saved link, matching the sidebarlib/people, matching Build the Platform Core, Chat, and member integrations UI #9687ResourceLoadErrorthey orphaned;LinksSurfacebecomes a sharedRedesignPageSurfaceDesign-system additions, each with a People consumer:
SearchCombobox, Avatarrow/card/hero, DataTableprimaryandrowChevron, SearchableSelectvariant='text',usersandminusglyphs. EmptyState now lays out its own action row instead of restyling anydivit is given.Where the prototype and the #9687 contract disagree, this follows the contract:
ModalchromeDeliberate departures from the prototype:
ActivityRow, whose leading slot can't hold it (the contract asks for first-line alignment)ControlRow)Heads up for #9687: its branch has its own
people/tree at many of the same paths, so that rebase needs to pick this implementation.Type of Change
Testing
test-people-e2e.tsagainst a running app and real Postgres in hosted mode: 20/20, browser journey updated for the new UI and extended to the header entry pointstest-org-redesign-e2e.tsPeople phase updated; runs in CI, not run locallybun run --cwd apps/sim test lib/peopleand the organization layout test: 56 passedtype-check,lint,check:platform-css,check:source-conventions,check:comment-hygiene,check:file-names,check:utils,check:client-boundary,check:explicit-any,check:boundaries,check:test-patterns, block registrycheck:auditsand rootbun run testleft to CIChecklist
test-auditauthoring gate)