Repository navigation
fix(billing): close the Chat plan popup when its shell unmounts and name the organization's plan on organization routes - #9614
Merged
Conversation
…ame the organization's plan on organization routes
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Low impact] This PR appears safe to merge. SummaryCloses the Chat plan popup when its shell unmounts and corrects the upgrade message on organization routes.
Reviews (1) · Last reviewed commit: "fix(billing): close the Chat plan popup ..." · Reviewed by Greptile |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
open()caller (composer submit,sendMessage, Send now): each runs synchronously from a user action, never in the same commit as a navigation, so the unmount cleanup cannot close a fresh refusal. StrictMode's dev double-invoke runs the cleanup while the store is already closedChecklist
test-auditauthoring gate)