Repository navigation
fix(ui): disable MCP URL edits and table rename for roles the server refuses - #9599
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] This PR appears safe to merge; both controls match the server’s permission rules. SummaryThis PR makes two controls match the server’s permission rules:
No actionable issues were found. Runtime and visual checks were not run because dependencies are absent from both the repository root and Reviews (1) · Last reviewed commit: "fix(ui): disable MCP URL edits and table..." · Reviewed by Greptile |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
allowDestinationChangeis admin-only). The URL field is now disabled with a hint for non-admins on edit; creating a server is unchanged (write)tables.updaterequires write. Rename now disables like the tables list and files doType of Change
Testing
bun run lint,check:source-conventions,check:comment-hygiene, pre-pushtype-checkapi/mcp/servers/[id],tables.updatewrite operation)Checklist
test-auditauthoring gate)