Skip to content

fix(ui): disable MCP URL edits and table rename for roles the server refuses - #9599

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/ui-gates-match-server
Nov 3, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
fix/ui-gates-match-server

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 3, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • MCP server edit modal let write-permission users change the server URL, which the server always refuses for non-admins (allowDestinationChange is admin-only). The URL field is now disabled with a hint for non-admins on edit; creating a server is unchanged (write)
  • Table detail page Rename was enabled for read-only users while Delete beside it was gated; tables.update requires write. Rename now disables like the tables list and files do

Type of Change

  • Bug fix

Testing

  • bun run lint, check:source-conventions, check:comment-hygiene, pre-push type-check
  • Verified both server policies before gating (PATCH api/mcp/servers/[id], tables.update write operation)

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 3, 2026 2:42am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] This PR appears safe to merge; both controls match the server’s permission rules.

Summary

This PR makes two controls match the server’s permission rules:

  • MCP server editors can change URLs only when they are workspace admins.
  • Table detail menus enable Rename only for users with edit access.

No actionable issues were found. Runtime and visual checks were not run because dependencies are absent from both the repository root and apps/sim.

Reviews (1) · Last reviewed commit: "fix(ui): disable MCP URL edits and table..." · Reviewed by Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit b3a3dda into staging Nov 3, 2026
74 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/ui-gates-match-server branch November 3, 2026 03:02

This branch was previously deployed

1 inactive deployment
Preview — 11ad9801 Deployed Nov 3, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant