[waleedlatif1]

Summary

• The terminal tool's approval gate only held run. input went through ungated, and on a tmux-attached terminal the desktop types it into the pane's shell prompt and presses Enter, so an input call could run a command line with no approval card
• terminalOperationNeedsApproval now gates every operation except an explicit allowlist that never delivers keystrokes (read, list, cwd, panes, new, switch, close, kill, handoff) — the same set that was ungated before, minus input
• Fails closed: an unknown or missing operation, or one added to the protocol later, is gated until someone deliberately allowlists it
• Keys-only input is gated too: up + enter re-runs the last shell command. Interrupting stays ungated through kill
• Gate stays server-side on the persisted row, so it binds every shipped desktop build without an app update

Type of Change

• Bug fix

Testing

• New cases in permission.test.ts (typed-text input, keys-only input, unknown operation, missing operation) fail on the pre-fix code and pass after
• lib/mothership/request/tools/ + lib/mothership/request/handlers/ suites: 362/362 passing
• bun run lint clean
• Checked side effects: the desktop's quick-op timeout and the renderer's client start both begin only after approval, so a gated input does not time out while the card waits; the approval card's tooltip shows the full args, including the text to be typed

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing (new tests pass the test-audit authoring gate)
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

🤖 Generated with Claude Code

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
docs	Skipped		Nov 2, 2026 8:33pm UTC

[greptile-apps]

Confidence Score: 5/5

[Medium impact] The PR appears safe to merge; no blocking issues were found.

Summary

Terminal input now requires approval, including keys-only calls. Unknown or missing operations also require approval.

• Terminal input now waits for approval before the desktop can send it.

_{Reviews (2) · Last reviewed commit: "fix(copilot): claim an ungated terminal ..." · Reviewed by Greptile}

[cubic-dev-ai]

All reported issues were addressed across 2 files

<sub>Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic</sub>

[waleedlatif1]

@greptile

[waleedlatif1]

@cubic-dev-ai review this PR

[cubic-dev-ai]

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

[cubic-dev-ai]

No issues found across 3 files

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.

_{Turn on auto-fix | Re-trigger cubic}