Repository navigation
fix(copilot): require approval for run_block and run_from_block - #9573
Merged
Merged
Conversation
All four workflow run tools reach the same executor, but the catalog only gated run_workflow and run_workflow_until_block. The approval gate is a pure catalog lookup, so an agent steered into run_from_block (which runs every block downstream of its start) or run_block executed the workflow with no approval card. Flag both siblings and assert every tool in WORKFLOW_TOOL_NAMES carries requiresApproval.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
Contributor
[Medium impact] This PR appears safe to merge. SummaryAdds approval prompts for
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run_blockandrun_from_blockasrequiresApprovalin the generated tool catalog, so all four workflow run tools draw the approval cardtoolCallNeedsApproval) is a pure catalog lookup; without the flag an agent steered intorun_from_blockran everything downstream of its start block, or ran a Function block it had just added withedit_workflow, with no approval decisionmship-tools:generate, which would pull in unrelated in-flight catalog driftWORKFLOW_TOOL_NAMEScarriesrequiresApproval, so a re-sync that drops the flag fails CIType of Change
Testing
run_block,run_from_block), passes afterpermission.test.ts,router.test.ts,run-tool-execution.test.ts,copilot/confirm/route.test.ts,async-runs/repository.test.ts,run-workflow-result-budget.test.ts,request/handlers,tool-executor,copilot/toolssuites: 269 + 38 passingbun run lintclean; type-check,check:audits, and the full suite left to CIChecklist
test-auditauthoring gate)Companion: simstudioai/mothership#899