Remove the bundled csi-driver-host-path and its dangling StorageClass - #465
Open
boddumanohar wants to merge 1 commit into
Open
boddumanohar wants to merge 1 commit into
boddumanohar wants to merge 1 commit into
Conversation
controlplane.csiHostpathDriver installs the upstream csi-driver-host-path project (CSIDriver, RBAC, DaemonSet) but defaults to disabled and has no caller in this chart depending on it. templates/controlplane_storageclass.yaml created a "local-hostpath" StorageClass for provisioner hostpath.csi.k8s.io gated only on operator.enabled (true by default) — independently of whether the driver providing that provisioner was ever installed, so it rendered a StorageClass with no matching CSI driver on a default install. Removed together with the driver rather than left dangling. controlplane.storageclass.name/allowedTopologyZones are kept: FDB's and Thanos's PVCs read them as a generic StorageClass override unrelated to this driver. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
noctarius
force-pushed
the
main
branch
2 times, most recently
from
September 9, 2026 10:21
60dceb7 to
fbaabe4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
templates/controlplane_csi-hostpath.yaml— the bundled upstreamcsi-driver-host-pathproject (CSIDriver, ServiceAccount, ClusterRole/Binding, DaemonSet), gated bycontrolplane.csiHostpathDriver.enabled(defaultsfalse), plus the matchingcontrolplane.csiHostpathDrivervalues block (5 image references).templates/controlplane_storageclass.yaml— alocal-hostpathStorageClass forprovisioner: hostpath.csi.k8s.io, gated only by.Values.operator.enabled(trueby default), independent ofcsiHostpathDriver.enabled. This rendered on every default install regardless of whether the driver providing that provisioner was ever installed — a StorageClass pointing at a nonexistent CSI driver by default. Removed together with the driver rather than left dangling.Kept
controlplane.storageclass.name/.allowedTopologyZones— FDB's and Thanos's PVCs (controlplane_foundationdb.yaml:343-344,controlplane_deploy.yaml:1283-1284,1293-1294) read these as a generic "which StorageClass should these PVCs use" override, unrelated to whether this specific driver exists.Test plan
helm lint helm-charts/charts/simplyblock-operator/helm templaterenders cleanly with defaults and withoperator.enabled=true --set controlplane.observability.enabled=truecsiHostpathDriver,hostpath.csi.k8s.io,csi-hostpathplugin-sa, orlocal-hostpathvalues.yamlare outside this diff (pure deletions only), unrelated debt🤖 Generated with Claude Code