Strip dead values.yaml keys - #462
Open
boddumanohar wants to merge 2 commits into
Open
boddumanohar wants to merge 2 commits into
boddumanohar wants to merge 2 commits into
Conversation
noctarius
force-pushed
the
main
branch
2 times, most recently
from
September 9, 2026 10:21
60dceb7 to
fbaabe4
Compare
boddumanohar
force-pushed
the
helm-values-cleanup
branch
2 times, most recently
from
September 14, 2026 13:13
dcd1c8a to
9bac8f3
Compare
boddumanohar
changed the title
Found while auditing values.yaml for dead configuration: leaf values with no live template reference anywhere in the chart. - spdkdev.create, benchmarks — zero references anywhere in the chart. - storagenode.numDataChunks, numParityChunks, journalManager — superseded by the cluster-scoped StripeSpec/enableJournalDevice sizing fields (PR #446/#448). - controlplane.observability.graylog.pullPolicy, .retentionPeriod, grafana.pullPolicy, thanos.pullPolicy — repository/tag are wired for all three containers, but none of them sets imagePullPolicy at all (falls back to the Kubernetes default), so these four were pure dead config. - logicalVolume.* (the whole block) — templates/job.yaml, its last live reader, has since been deleted; nothing in the chart reads any of these keys anymore. The controller.yaml tolerations/imagePullPolicy copy-paste fixes from the original version of this change are dropped: templates/controller.yaml was deleted from main when the CSI controller moved to the SimplyblockDriver CRD (#513), so that file and its bug no longer exist. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
boddumanohar
force-pushed
the
helm-values-cleanup
branch
from
September 14, 2026 13:16
9bac8f3 to
4e04b12
Compare
storagenode.create gated a helm-based DaemonSet/ServiceAccount/ClusterRole deployment of storage nodes, superseded by the operator's StorageNodeSet reconciler. It defaults to false and nothing still relies on the chart having created these. multiCluster was the one live sub-key, read outside the create gate by the CSI secret and event-alert templates, so it moves to the top level instead of being deleted with the rest. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
geoffrey1330
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Found while auditing
values.yamlfor dead configuration: leaf values with no live template reference anywhere in the chart.Dead values removed
spdkdev.create,benchmarks— zero references anywhere in the chart.storagenode.numDataChunks,storagenode.numParityChunks,storagenode.journalManager— superseded by the cluster-scopedStripeSpec/enableJournalDevicesizing fields (PR refactor(api): make storage-node sizing cluster-scoped, replace partitions with enableJournalDevice #446/fixup(api): make storage-node sizing cluster-scoped, replace parti… #448).controlplane.observability.graylog.pullPolicy,.retentionPeriod,.grafana.pullPolicy,.thanos.pullPolicy— repository/tag are wired for all three containers, but none of them setsimagePullPolicyat all (falls back to the Kubernetes default), so these four were pure dead config.logicalVolume.*(the whole block:pool_name, the QoS knobs,encryption,numDataChunks/numParityChunks,max_namespace_per_subsys,tune2fs_reserved_blocks,fabric) — its last live reader,templates/job.yaml, has since been deleted, so nothing in the chart reads any of these keys anymore.Test plan
helm lint helm-charts/charts/simplyblock-operator/helm templaterenders cleanly with defaultsmain🤖 Generated with Claude Code