feat(storagecluster): add checksum validation fields - #434
Merged
Merged
Conversation
1 task
boddumanohar
force-pushed
the
feat/checksum-validation
branch
from
August 17, 2026 18:31
6d10050 to
5f86e19
Compare
boddumanohar
force-pushed
the
feat/checksum-validation
branch
from
August 21, 2026 12:00
e06fbe4 to
d9dfde1
Compare
noctarius
force-pushed
the
main
branch
2 times, most recently
from
September 9, 2026 10:21
60dceb7 to
fbaabe4
Compare
boddumanohar
force-pushed
the
feat/checksum-validation
branch
from
September 10, 2026 07:19
d9dfde1 to
d5e2c40
Compare
boddumanohar
marked this pull request as ready for review
September 10, 2026 07:20
boddumanohar
force-pushed
the
feat/checksum-validation
branch
3 times, most recently
from
September 10, 2026 09:38
8a6bc2d to
b5b16e3
Compare
boddumanohar
requested review from
geoffrey1330 and
noctarius
and removed request for
noctarius
September 10, 2026 09:48
Expose spec.enableChecksumValidation and spec.enableAtomic4kWrites on StorageCluster and pass them through to the backend as inline_checksum and atomic_4k during cluster creation. Validate that enableAtomic4kWrites requires enableChecksumValidation, keep both fields immutable after cluster creation, and regenerate CRDs, Helm chart CRD, embedded upgrade CRD, deepcopy code, and the installer.
boddumanohar
force-pushed
the
feat/checksum-validation
branch
from
September 10, 2026 11:17
e37a329 to
90c4d4f
Compare
noctarius
approved these changes
Sep 10, 2026
geoffrey1330
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #433
Exposes sbcli's inline CRC checksum validation (silent-data-error protection, design ref TD.100226.1) as cluster-level StorageCluster spec fields.
enableChecksumValidationenables checksum validation on every I/O. This alone is enough; on drives with a native 4K logical block size it is the normal case.enableAtomic4kWritessets the backend'scv_ignore_block_size, letting checksum validation run on devices that report a 512B logical block size but guarantee 4K write atomicity. It requiresenableChecksumValidation; with checksums off, the backend never sends the parameter at all.bdev_alceml_createcall at cluster-create time and never re-applied.The operator maps these Kubernetes-facing fields into
ClusterAddParamsforPOST /api/v2/clusters/asinline_checksumandatomic_4k, matching the merged sbcli API fields.Accepted combinations