chore: retire the io.simplyblock.node-type label references (blocked on R25 EOL) - #1334
Closed
boddumanohar wants to merge 1 commit into
Closed
chore: retire the io.simplyblock.node-type label references (blocked on R25 EOL)#1334boddumanohar wants to merge 1 commit into
boddumanohar wants to merge 1 commit into
Conversation
DO NOT MERGE while R25.x is a supported upgrade source. Parked as a draft so the work is ready when it stops being one. simplyblock-operator #508 retires io.simplyblock.node-type on the operator side: it was written onto exactly the nodes io.simplyblock.storagenodeset already marked and removed with them, so it carried no information the per-set label did not, and its two consumers now select the per-set label instead. The four references here are the other half of that key's life. They are the legacy R25 path, where an administrator labels workers by hand and the R25 spdk-csi chart's storagenode.create DaemonSet matches on the unsuffixed value simplyblock-storage-plane, as does the CSI driver's mgmt-api job. Nothing here ever referenced the cluster-suffixed value the operator wrote, so #508 did not make any of it stale. Removed: - UPGRADE.md, section 1.3, which labeled the workers before the R25 chart install; 1.4 and 1.5 renumber - R25_MANUAL_SETUP_STEPS.md, the labeling loop in Phase 4, whose heading loses "Label workers +" - .github/workflows/k8s-native-upgrade.yaml, the "Label worker nodes for R25 storage plane" step of the r25-to-r2x job - e2e/scripts/cleanup_upgrade_test.sh, the teardown that stripped the label in Phase 10 Merging before R25 is dropped breaks the r25-to-r2x CI job and leaves UPGRADE.md telling a reader to install a chart whose nodeSelector nothing satisfies. It also has to land with, or after, the removal of the chart's storagenode.create branch and the mgmt-api job's label_selector in the simplyblock-operator repository, which are what actually consume the label. Verified: the workflow still parses as YAML, the cleanup script still passes bash -n, and no io.simplyblock.node-type reference remains in this repository. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
boddumanohar
marked this pull request as ready for review
September 10, 2026 12:03
boddumanohar
marked this pull request as draft
September 10, 2026 12:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this exists
simplyblock-operator#508 retires
io.simplyblock.node-typeon the operator side: it was written onto exactly the nodesio.simplyblock.storagenodesetalready marked and removed with them, so it carried no information the per-set label did not.The four references here are the other half of that key's life — the legacy R25 path, where an administrator labels workers by hand and the R25 spdk-csi chart's
storagenode.createDaemonSet matches on the unsuffixed valuesimplyblock-storage-plane, as does the CSI driver's mgmt-api job. Nothing here referenced the cluster-suffixed value the operator wrote, so #508 did not make any of this stale.Removed
UPGRADE.mdR25_MANUAL_SETUP_STEPS.md.github/workflows/k8s-native-upgrade.yamlr25-to-r2xjobe2e/scripts/cleanup_upgrade_test.shWhy it is blocked
r25-to-r2xis still a liveupgrade_typein the upgrade workflow, andUPGRADE.mdis the maintained R25.x to R26+ guide. Merging now would:r25-to-r2xCI job, since storage-node pods would have no node to schedule onUPGRADE.mdinstructing a reader to install a chart whosenodeSelectornothing satisfiesWhat must land with it
The consumers live in the operator repo and are untouched by #508 by design:
storagenode.createDaemonSetnodeSelectorlabel_selector = "io.simplyblock.node-type=simplyblock-storage-plane"This PR is only correct once those are gone, i.e. when R25 is no longer a supported upgrade source.
Checks
The workflow still parses as YAML, the cleanup script still passes
bash -n, and noio.simplyblock.node-typereference remains in this repository.🤖 Generated with Claude Code