logging: add requestID for access logs, application logs and traceback logs#1064
Open
boddumanohar wants to merge 1 commit into
Open
logging: add requestID for access logs, application logs and traceback logs#1064boddumanohar wants to merge 1 commit into
requestID for access logs, application logs and traceback logs#1064boddumanohar wants to merge 1 commit into
Conversation
…and traceback logs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently in the WebApp API we have see 3 types of logs:
POST /cluster/<uid>.. 20ms "Go clientERROR: failed to clone volumeTraceback: ...To allow us to connect all these 3 together, have added a new field
request_idto the logging filter.So at the start of the request, within the middleware, we inject the request_id
and then reset it after the request ends
But since the update has been to the core logger,
simplyblock_core/utils/__init__.pyfor CLI, output, we'll see the extra [-] in between.testing
TODO