Repository navigation
ci: wildcard listeners for develop and production, and the S3 checksum setting for production - #373
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (8)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wildcard listeners (develop and production). Both jobs now set
gateway-section-name: https-wildcard-bitween-io, soapp-dev.bitween.ioandapp.bitween.iouse their gateway's*.bitween.iowildcard listener and certificate. Without it, the deploy creates a listener and certificate for each host. Before Helm runs, the deploy checks that the listener exists (simplify9/.github#190).S3 checksum (production only). Production stores files in DigitalOcean Spaces, like develop. Develop sets
AWS_REQUEST_CHECKSUM_CALCULATIONandAWS_RESPONSE_CHECKSUM_VALIDATIONtowhen_required, because AWSSDK.S3 3.7.410+ sends uploads aws-chunked with a trailing checksum, and S3-compatible stores save that into the object (C3;chunk-signature=...). The production deploy now sets the same two values. The lasting fix still belongs in SW-CloudFiles.Merge order
gateway-section-nameis ignored for these hosts.*.bitween.iowildcard listener must be live and theapp-dev.bitween.iolisteners removed. A host-specific listener takes the host away from the wildcard, so this route, now attached only to the wildcard, would answer 404.docs/deployment.mdis updated to match.