Skip to content

ci: wildcard listeners for develop and production, and the S3 checksum setting for production - #373

Merged
MusaMisto merged 3 commits into
releases/r10.0-developfrom
musa/ci/prod-aws-checksum
Oct 12, 2026
Merged

MusaMisto merged 3 commits into
releases/r10.0-developfrom
musa/ci/prod-aws-checksum

Conversation

@MusaMisto

@MusaMisto MusaMisto commented Oct 12, 2026 •

Copy link
Copy Markdown
Member

Wildcard listeners (develop and production). Both jobs now set gateway-section-name: https-wildcard-bitween-io, so app-dev.bitween.io and app.bitween.io use their gateway's *.bitween.io wildcard listener and certificate. Without it, the deploy creates a listener and certificate for each host. Before Helm runs, the deploy checks that the listener exists (simplify9/.github#190).

S3 checksum (production only). Production stores files in DigitalOcean Spaces, like develop. Develop sets AWS_REQUEST_CHECKSUM_CALCULATION and AWS_RESPONSE_CHECKSUM_VALIDATION to when_required, because AWSSDK.S3 3.7.410+ sends uploads aws-chunked with a trailing checksum, and S3-compatible stores save that into the object (C3;chunk-signature=...). The production deploy now sets the same two values. The lasting fix still belongs in SW-CloudFiles.

Merge order

  1. reusable-service-cicd: gateway-section-name attaches any host to a shared listener .github#190. Until it's merged, gateway-section-name is ignored for these hosts.
  2. On the dev gateway, the *.bitween.io wildcard listener must be live and the app-dev.bitween.io listeners removed. A host-specific listener takes the host away from the wildcard, so this route, now attached only to the wildcard, would answer 404.
    • If this merges before the wildcard exists, the develop deploy just fails its listener check before Helm runs. Nothing changes on the cluster.

docs/deployment.md is updated to match.

@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (8)
  • ^main$
  • ^master$
  • ^staging$
  • ^development$
  • ^gigstaging$
  • ^develop$
  • ^releases$
  • ^releases/r10.0$

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: simplify9/coderabbit/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 932e3c02-c563-44ee-b1cd-fc21ac7babd6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@MusaMisto MusaMisto changed the title ci: carry the S3 checksum setting into production ci: production deploy uses the S3 checksum setting and the *.bitween.io wildcard listener Oct 12, 2026
@MusaMisto MusaMisto changed the title ci: production deploy uses the S3 checksum setting and the *.bitween.io wildcard listener ci: wildcard listeners for develop and production, and the S3 checksum setting for production Oct 12, 2026
@MusaMisto
MusaMisto merged commit f9e061a into releases/r10.0-develop Oct 12, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant