Repository navigation
Chart: route / by default, alongside /api and /swagger (r10.0-staging) - #353
Merged
MusaMisto merged 1 commit intoOct 11, 2026
Merged
Conversation
The Ingress exposed only /api and /swagger, so the admin SPA at / stayed on whatever else served the host unless every deployment remembered to add it. A deployment that tried (`ingress.path=/api, /`) found that `ingress.path` is ignored whenever `ingress.paths` is set, which it always is by default. ingress.paths now defaults to [/api, /swagger, /], and ingress.path, the fallback for an empty list, is / too. Gateway mode already routes / and renders unchanged.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (8)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The chart's Ingress exposed only
/apiand/swaggerby default, so the admin SPA served from this image'swwwrootat/wasn't routed unless every deployment added/itself. GIG tried withingress.path=/api, /, and it couldn't work:ingress.pathis only used wheningress.pathsis empty, andingress.pathsalways has a default. The prod deploy failed, and the/rule ended up added by hand withkubectl patch.Change
ingress.pathsdefaults to[/api, /swagger, /]./apistays first, so NOTES still points at the API.ingress.path(the root key, used only whenpathsis empty) is/instead of/api.charts/default/README.md,docs/deployment.mdand thevalues.yamlcomment describe the new default.The same change is open on releases/r10.0 and releases/r10.0-staging. The two hunks are identical, so the next staging -> r10.0 merge applies cleanly.
Verification
Each branch was compared with its own base:
helm lint --strictpasses./rule (pathType: ImplementationSpecific, which ingress-nginx matches as a prefix, like the existing two).gateway.enabled=true): the render is byte-identical.ingress.paths={/api}: still renders only/api. Overrides replace the list, as before.ingress.paths=null: now falls back to/(was/api).After merge
Merging triggers the staging build and playground deploy. The playground uses Gateway API mode, whose render is unchanged.