test: fewer e2e tests, more unit and component tests - #324
Merged
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The e2e suite had grown to 155 tests, and half of them were mapping-engine or single-page checks driven through a browser. This moves each check to the fastest layer that can see it.
src/__tests__/support). A request with no handler fails the test.tsc -bandyarn test. Nothing ran the frontend tests before.CONTRIBUTING.mdsays which layer a new test goes in.One commit per step. Local results: 428 frontend tests pass; backend unit 539/539; e2e 34/36. The two failures are a 2px scheduled-jobs overflow caused by local data, not this change. Integration failures locally are adapter packages not built on this machine, plus three
AuditTrailTeststhat fail on r10.0 too.