UI and build cleanups - #320
Conversation
The scroll listener is on document in the capture phase, so any scrolling element on the page closed the panel — including a pane that had only re-rendered elsewhere. Defaults to the old behaviour.
The formats and their CSV options move behind a "JSON -> CSV" chip, which stops the row jumping width when a side changes format. Back/title, rule actions and editor state are now separated rather than all at one level.
Chunks are named after their content, so nothing overwrote anything and the folder only grew — 146 files and 178MB of superseded bundles, all servable. Only assets/, since the rest of wwwroot is legacy content the SPA does not own.
getSession turned every failure into "signed out", so a busy or briefly unreachable backend sent people to the sign-in page mid-task with a perfectly good token still in localStorage. Only a refused token ends the session now; anything else shows an outage with a retry.
|
Understand this PR’s impact Explore downstream dependencies and potential security impact with Blast Radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: simplify9/coderabbit/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (12)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📜 Recent review details🔇 Additional comments (12)
📝 SummarySummary
Riskrisk:medium Session state and sign-out behavior changed. Build cleanup also affects generated deployment assets. Security-sensitive areas
Test coverage impact
Operational concerns
WalkthroughThe pull request adds session outage handling with retry support, moves mapper format controls into a popover, centralizes related end-to-end interactions, updates mapper selection coverage, and selectively cleans Vite assets before builds. ChangesSession outage handling
Mapper settings interaction
Asset build cleanup
Priority: ➖ Normal Estimated code review effort: 4 (Complex) | ~45 minutes Change: Bug fix Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2 participants
Four small fixes, one per commit.
JSON → CSVchip, which also stops the row jumping width when a side changes format.documentin the capture phase. A pane re-rendering elsewhere was enough to shut it under you. Opt-out prop, default unchanged.assets/only.getSessionturned every failure into "signed out", so a busy or briefly unreachable backend sent people to the sign-in page mid-task with a good token still in localStorage. Only a refused token ends the session now; anything else shows an outage with a retry.Verified in the browser, plus the four mapper specs and a new
session-outage.spec.ts(5 tests).