Six small backlog items - #314
Merged
Merged
Conversation
HAM-71 log the document store reads and writes, not the key building
HAM-72 name a pipeline stage for its state, not always in the past tense
HAM-75 offer "+ New" for a retry policy where work group already does
HAM-76 stop Back reopening a create form that was just submitted
HAM-81 show a work group's queue, so two of the same name differ
HAM-83 cap a run's exchange column and link the rest to Exchanges,
via a new ReceiveAttemptId search filter
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: simplify9/coderabbit/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (19)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📜 Recent review details🔇 Additional comments (17)
📝 SummarySummary
Risk: Security-sensitive areas touched
Test coverage impact
Operational concerns
WalkthroughChangesReceive-attempt filtering
File operation logging
Web configuration workflows
Exchange presentation and navigation
Priority: ⬇️ Low Estimated code review effort: 4 (Complex) | ~45 minutes Change: Bug fix Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
AhmadRAbuhussein
approved these changes
Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backlog cleanup — six unrelated small fixes, one per issue.
+ Newthat work group already had.CreateRetryPolicyDialogmoved tocomponents/config/.?new=1history entry, so Back no longer reopens the form. Hit global values, retry policies and notifiers.The one piece worth review
HAM-83 needed a new
ReceiveAttemptIdsearch filter. Linking with?ids=a,b,cmeant a 1,433-character URL for 43 exchanges, and would have broken outright on a large run.XchangeFilters.ResolveReceiveAttemptFilterAsyncreads the run and rewrites the filter into the existingId/Containsone, so the result set is identical to the long URL it replaces. It resolves before the query rather than as a subquery becauseReceiveAttempt.ExchangeIdsis persisted as a separator-delimited string, not an array, and the solution ships on three DB providers. AReceiveAttemptIdcolumn on the exchange table was the alternative and would have needed a migration and backfill.Called from both
Xchanges/SearchandBulkRetryPlanner.SelectionQuery(now async), so a "select all matching" over a run acts on exactly the rows the list showed. A missing run and a run that created nothing both refuse rather than silently widening to every exchange.Tests
ReceiveAttemptFilterTests(3, new) — passingjourneyStages.test.ts(5, new) — covers the Processing case local data can't produceIntegration suite — do not merge on my word yet
143 of 449 failed locally. They are concentrated in areas this branch does not touch — the database adapters (MySql, Oracle, SqlServer, PostgreSql), the bus gateways (Rabbit, SQS, external), resident/serverless adapters, and
BusProviderSupervisorTests, which never brings an adapter up and burns a 45s timeout per test.Two of them are confirmed pre-existing: run on a clean worktree of
origin/releases/r10.0with none of this branch's changes,A_superseded_lease_stops_the_adapter_before_anything_elseandReconciling_starts_the_adapter_for_an_active_data_sourcefail identically — same assertions, same line numbers, same timings.The shape of the list strongly suggests a local environment problem rather than a regression, but I have not yet proven that for the other 141. A full run against the base branch is in progress; I will post the comparison here before this is merged.