Name the account on the forced password change, and offer a way out - #313
Conversation
The screen is reached by redirect, so whoever lands there did not ask for it: it now says which account it means, and offers signing in as someone else. Without that it was a trap — every route redirects back to it, so reaching it on the wrong account left no way in but clearing cookies. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: simplify9/coderabbit/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📜 Recent review details🔇 Additional comments (1)
📝 SummarySummary
Risk: Security-sensitive areas
Test coverage impact
Operational concerns
WalkthroughThe change password page now shows the signed-in account email and provides a button to sign out and use another account. ChangesChange password account context
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested labels: Suggested reviewers: Merge Risk: ⚪ Minimal · up to The update appears limited to showing the active account and providing an alternate sign-in exit, with no unresolved merge-blocking risk identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Warning Git: CodeRabbit could not clone the repository, so clone-backed analysis was skipped and this review may be incomplete. Verify repository clone access, such as SSH credentials, before requesting another full review. If clone access is intentionally unavailable, use Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Follow-up to the forced password change added in #311.
That screen is reached by redirect rather than by choice, and it was a dead end: it never said which account it was talking about, and every route redirects back to it — so landing on it with the wrong account left no way in short of clearing cookies.
Now it names the account and offers signing in as someone else.
Why the screen exists at all
The seeded administrator ships with a password published in this repository. Until that password is replaced, the account's token grants nothing, so there is no usable app to land in — every page would refuse. The dead-end screen is the honest presentation of a dead-end token; a banner inside the app would stop a browser and nobody using curl.
It only fires for accounts still holding the shipped password. Everyone else signs in and lands on the dashboard as before.
Verified
Driven in a real browser against a local database with the flag set:
/change-password, headed "Choose a password", showingSigned in as admin@Bitween.systemsGET /api/partners→ 401/login/dashboard,/partnersopensTypecheck and the 344 client tests pass.