List built-in and custom adapters separately - #302
Merged
Merged
Conversation
Adapter pickers offer the shipped adapters, with the custom ones behind a "Custom adapter…" row. Display names drop the Native prefix; stored ids are untouched and still shown on each row. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…re/adapter-picker-split
|
Warning Review limit reachedNext included review available in 35 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: simplify9/coderabbit/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
samerzughul
approved these changes
Sep 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes HAM-58.
Adapter pickers listed shipped and client-deployed adapters in one list, told apart only by a word at the end of each row — and that list grew with every deployment, so the common choice got harder to find the more an instance was used. They now offer the built-in adapters, with the custom ones behind a single "Custom adapter…" row that opens a custom-only list.
Which list opens follows what is selected, so a subscription running a custom adapter shows it straight away. An adapter the catalog no longer lists still appears, flagged "Not in catalog" — the case where a picker would otherwise read as unconfigured on a subscription that is in fact wired up.
Also drops the
Nativeprefix from display names (NativeHttpHandler→HttpHandler). Display only: stored ids are untouched, still shown on every row, and still what the row is searchable by.NativeMappershows as "Visual mapper", since stripping would leave a bare "Mapper".Covers both adapter dropdowns in the app —
AdapterConfig(subscriptions, scheduled jobs, aggregations, gateway subscriptions, bus studio, retry-policy alert routing) and the notifier's "Deliver via".No backend change:
Catalogalready reportsNativeper adapter.Verified in the browser, with custom adapters injected via request interception since no instance here has any deployed.
subscriptions.spec.tsassertions updated for the new display names; its remaining failure is pre-existing and reproduces on a clean baseline build.🤖 Generated with Claude Code