Repository navigation
Fix NoSuchFileException in AbsolutePath.deleteRecursively - #89
Merged
Merged
Conversation
deleteRecursively walked the path unconditionally, so Files.walk threw NoSuchFileException when the target directory did not exist yet (e.g. the first didSave before classesDir is populated). Guard the walk on existence, matching the rm -rf semantics already implied by the internal deleteIfExists. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
AbsolutePath.deleteRecursivelycalledFiles.walk(ap)unconditionally. When the target directory doesn't exist,Files.walkthrowsNoSuchFileExceptionrather than no-opping. This surfaced ondidSave(ServerImpl.handleDidSave), wheretargetInfo.classesDir.deleteRecursivelyruns before the classes dir has been populated:Fix
Guard the walk on existence. This matches the
rm -rfsemantics already implied by the internaldeleteIfExists, and makes all three callers (ServerImplx2,TastyIndexer) safe against missing paths.🤖 Generated with Claude Code