Repository navigation
Index phase 4: seal the index module boundary - #84
Merged
Merged
Conversation
ProjectIndex and DependencyIndex become `private[index]`. SymbolIndex's
`project` / `dependency` are now `private[index] val` so IndexManager
(same package) keeps write access while everything outside the index
package only sees the SymbolIndex façade.
IndexManager takes a SymbolIndex (not the two raw stores) and owns
`updateOpenFile(uri, syms, refs)` — the new verb replacing the
`symbolIndex.project.updateFiles(...)` reach-through in
ServerImpl.pcDiagnostics. Introspection (`projectSymbolCount`,
`dependencySymbolCount`, `fileCount`, `jarCount`, `allReferenceTargets`
— renamed from the dishonest `debugReferenceKeys`) lives on SymbolIndex.
SimpleLanguageServer builds the façade via `SymbolIndex.empty`; it no
longer names ProjectIndex / DependencyIndex.
Both phase-4 grep success criteria are zero hits:
grep -r "ProjectIndex\|DependencyIndex" sls/src
outside sls/src/org/scala/abusers/sls/index/
grep -r "symbolIndex.project\|symbolIndex.dependency" sls/src
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
`defaultWithAlign` should line up the `=` of the five adjacent introspection defs at the column of the widest signature (`allReferenceTargets`). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProjectIndexandDependencyIndexare nowprivate[index].SymbolIndex'sproject/dependencyconstructor params becomeprivate[index] valsoIndexManagerkeeps write access while everything outside the package only sees theSymbolIndexfaçade.IndexManagertakes aSymbolIndex(not the two raw stores) and exposesupdateOpenFile(uri, syms, refs)— the new verb replacing thesymbolIndex.project.updateFiles(...)reach-through inServerImpl.pcDiagnostics.projectSymbolCount,dependencySymbolCount,fileCount,jarCount,allReferenceTargets— renamed from the dishonestdebugReferenceKeys) lives onSymbolIndex.SimpleLanguageServerbuilds the façade viaSymbolIndex.emptyand no longer namesProjectIndex/DependencyIndex.Phase 4 success criteria
Both greps from
ai/architecture-improvements.mdreturn zero hits:Test plan
./mill __.compileclean./mill sls.testgreen (598/598)🤖 Generated with Claude Code