Repository navigation
Index phase 3: CoreState dedup for ProjectIndex/DependencyIndex - #82
Merged
Merged
Conversation
Extract `private[index] CoreState(symbols, nameTrie, camelCaseTrie, subtypes)` with `add(List[IndexedSymbol])` / `remove(Set[SymbolId])`. ProjectIndex.State wraps `core + byFile + references + refsByFile`; DependencyIndex.State wraps `core + jarFilters + symbolJar`. The var-accumulator trie loops collapse to `foldLeft` over CoreState; wrapping state-update sites are ~11-22 lines each (down from ~41-55). Bloom filters stay on DependencyIndex per plan. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Seals the only site that mutated CoreState fields outside its add/remove API, so future invariants in CoreState can't be silently bypassed. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
private[index] CoreState(symbols, nameTrie, camelCaseTrie, subtypes)with pureadd(List[IndexedSymbol])/remove(Set[SymbolId])helpers — the trie/subtypes scaffolding now lives in one place.ProjectIndex.Statewrapscore + byFile + references + refsByFile;DependencyIndex.Statewrapscore + jarFilters + symbolJar. Bloom filters stay onDependencyIndexper the architecture plan.var nameTrie = ...; nameTrie = nameTrie.insert(...)accumulator loops collapse tofoldLeftoverCoreState.add/CoreState.remove. Wrapping state-update sites are now ~11–22 lines each (down from ~41–55).Implements Phase 3 of
ai/architecture-improvements.md.Test plan
./mill sls.compile— clean./mill sls.test— 598/598 SUCCESS (including ProjectIndexSpec, DependencyIndexSpec, CrossProducerSpec, IndexManagerSpec, the reference-set / round-trip determinism specs)./mill sls.fix --check— clean🤖 Generated with Claude Code