Inventory: include any repo with issues+PRs enabled instead of a fork allow-list - #101
Open
silug wants to merge 2 commits into
Open
Inventory: include any repo with issues+PRs enabled instead of a fork allow-list#101silug wants to merge 2 commits into
silug wants to merge 2 commits into
Conversation
…allow-list The org now disables issues and pull requests on every fork that exists only as a mirror, so those two flags are the signal separating maintained repos (forks included) from mirrors — puppetsync's whole output is a PR, so a repo that can't receive one is definitionally out. The exclude_forks/include_forks allow-list is retired (passing the old keys warns and is ignored); the puppetsync-ignore topic and exclude globs remain as escape hatches, and pupmod-voxpupuli-selinux stays out via an explicit exclude until #83 is fixed. Verified against the live org: the generated inventory matches the last real run's snapshot except for two corrections — pupmod-simp-haveged (a maintained fork the old allow-list silently dropped, so it missed the recent fleet sessions) and pupmod-simp-rngd (a brand-new module, discovered automatically). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
It never received the new baseline (the old fork rule silently dropped it) and is likely to be archived soon — at which point exclude_archived makes this entry redundant. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that issues and pull requests are disabled on every fork that exists only as a mirror, the dynamic inventory no longer needs the
include_forksallow-list: a repo is included iff issues AND pull requests are enabled (plus the existing name globs / topic / archived / empty filters). puppetsync's whole output is a PR, so a repo that can't receive one is definitionally out of scope.exclude_forks/include_forksare retired; passing them warns and is ignored. Thepuppetsync-ignoretopic andexcludeglobs remain as escape hatches.pupmod-voxpupuli-selinux(PRs enabled, so the new rule would include it) stays out via an explicitexcludeglob until GitHub PR stages can't use an existing fork-network sibling (e.g. silug/puppet-selinux for pupmod-voxpupuli-selinux) #83 is fixed and its CI is green — preserving the earlier deliberate hold.Verified against the live org (260 repos → 80 selected): the generated inventory matches the last real fleet run's snapshot except for two corrections, both in the new rule's favor:
pupmod-simp-haveged— a maintained fork (issues+PRs on) that the old allow-list silently dropped; it missed the recent fleet sessions and never received the new baseline. Since it is also likely to be archived soon, it is now held out via an explicitexcludeglob alongside pupmod-voxpupuli-selinux (archival will make the entry redundant).pupmod-simp-rngd— created yesterday; discovered automatically, as intended.Task specs rewritten for the new rule (either flag off ⇒ skipped; missing flags ⇒ included, so older API shapes can't empty the inventory; retired-key warning). 231 rspec + 28 BoltSpec examples green.
🤖 Generated with Claude Code