Exclude unsortable primary key from the sort menu - #2858
Open
Sanjays2402 wants to merge 1 commit into
Open
Conversation
When a table configures sortable_columns and omits the primary key, the sort dropdown still offered it. display_columns_and_rows() rebuilds the primary key as the leading link column and hardcoded its "sortable" flag to len(pks) == 1 instead of consulting sortable_columns, so selecting it produced a 500/400 "Cannot sort table by id" error. The flag now checks sortable_columns like every other column. Adds tests/test_table_html.py::test_sort_menu_excludes_unsortable_primary_key.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1980
When a table sets
sortable_columnswithout the primary key, the sort dropdown still listed it, so picking it returned "Cannot sort table by id".display_columns_and_rows()rebuilds the pk as the leading link column and hardcoded"sortable": len(pks) == 1instead of checkingsortable_columns; it now checks it like every other column.New test in
tests/test_table_html.pyfails without the change and passes with it.