Update the prelude to upstream facebook/buck2 as of 2484d70a6f8a - #10
Merged
Merged
Conversation
Brings prelude/ from upstream 1469fe7461 (2026-08-14, the snapshot this was originally taken from) forward to 2484d70a6f8a (2026-09-30, the commit buck2 release 2026-10-01 was built from): 368 upstream commits touching prelude/. The old snapshot passed `eager_materialization_enabled` to `ctx.actions.run`, so it could not be loaded by any buck2 release newer than 2026-09-01. The new one loads with 2026-10-01 and `latest`, and no longer with 2026-09-01 (it uses `root_values`). Done as a three-way merge (base: upstream at 1469fe7461; ours: the old prelude/; theirs: upstream at 2484d70a6f8a). Upstream touched none of our Haskell changes (haskell/*, decls/haskell_*.bzl, toolchains/haskell.bzl, third-party/pkgconfig.bzl); the only file changed on both sides was toolchains/demo.bzl, which merged without conflicts. Everything else is taken from upstream unchanged. CI is moved to the 2026-10-01 release to match. Tested with buck2 2026-10-01: example/ (TemplateHaskell, .hsc, C++ FFI) builds and tests in dev, opt and prof modes. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings prelude/ from upstream 1469fe7461 (2026-08-14, the snapshot this was originally taken from) forward to 2484d70a6f8a (2026-09-30, the commit buck2 release 2026-10-01 was built from): 368 upstream commits touching prelude/.
The old snapshot passed
eager_materialization_enabledtoctx.actions.run, so it could not be loaded by any buck2 release newer than 2026-09-01. The new one loads with 2026-10-01 andlatest, and no longer with 2026-09-01 (it usesroot_values).Done as a three-way merge (base: upstream at 1469fe7461; ours: the old prelude/; theirs: upstream at 2484d70a6f8a). Upstream touched none of our Haskell changes (haskell/, decls/haskell_.bzl, toolchains/haskell.bzl, third-party/pkgconfig.bzl); the only file changed on both sides was toolchains/demo.bzl, which merged without conflicts. Everything else is taken from upstream unchanged.
CI is moved to the 2026-10-01 release to match.
Tested with buck2 2026-10-01: example/ (TemplateHaskell, .hsc, C++ FFI) builds and tests in dev, opt and prof modes.