Repository navigation
Conversation
velocitysystems
left a comment
Contributor
There was a problem hiding this comment.
Please squash the review follow-up commits into the commits they amend before merge:
chore: sync example Tokio lockfileintofix: update vulnerable Rust dependenciesci: run pinned cargo-deny directlyintoci: check Rust dependencies with cargo-deny
Comment on lines
+509
to
+525
| Rust dependency policy is checked on pushes, pull requests, and weekly against the | ||
| committed lockfile. Install cargo-deny and run the same check locally: | ||
|
|
||
| ```bash | ||
| cargo install cargo-deny --version 0.20.2 --locked | ||
| cargo deny --workspace --all-features --locked check | ||
| ``` | ||
|
|
||
| `deny.toml` checks advisories, licenses, duplicate versions, and dependency sources | ||
| across all platforms, including development dependencies. Duplicate versions produce | ||
| warnings; wildcard dependencies and unapproved sources fail the check. The example | ||
| app has a separate lockfile and is not included in this audit. | ||
|
|
||
| Update affected dependencies before adding advisory exceptions. Each exception must | ||
| identify the upstream constraint and explain why an update cannot resolve it. Remove | ||
| exceptions when upstream dependencies no longer require them. Review license additions | ||
| and allow only the registries and Git repositories the package needs. |
Contributor
There was a problem hiding this comment.
Can we tighten this section? deny.toml is the source of truth for what's checked, and listing its settings here will drift.
Suggested change
| Rust dependency policy is checked on pushes, pull requests, and weekly against the | |
| committed lockfile. Install cargo-deny and run the same check locally: | |
| ```bash | |
| cargo install cargo-deny --version 0.20.2 --locked | |
| cargo deny --workspace --all-features --locked check | |
| ``` | |
| `deny.toml` checks advisories, licenses, duplicate versions, and dependency sources | |
| across all platforms, including development dependencies. Duplicate versions produce | |
| warnings; wildcard dependencies and unapproved sources fail the check. The example | |
| app has a separate lockfile and is not included in this audit. | |
| Update affected dependencies before adding advisory exceptions. Each exception must | |
| identify the upstream constraint and explain why an update cannot resolve it. Remove | |
| exceptions when upstream dependencies no longer require them. Review license additions | |
| and allow only the registries and Git repositories the package needs. | |
| Rust dependencies are checked with cargo-deny on every push and pull request. The example | |
| app has its own lockfile and is not checked. Run the same check locally: | |
| ```bash | |
| cargo install cargo-deny@0.20.2 --locked | |
| cargo deny --workspace --all-features --locked check | |
| ``` | |
| Fix advisories by updating the dependency where possible. Any exception in `deny.toml` | |
| must say why an update cannot resolve it. |
Contributor
Author
There was a problem hiding this comment.
Simplified the section as suggested, keeping the local commands and exception guidance.
| run: rustup toolchain install | ||
|
|
||
| - name: Install cargo-deny | ||
| run: cargo install cargo-deny@0.19.8 --locked |
Contributor
There was a problem hiding this comment.
Let's standardise on cargo-deny 0.20.2, the latest release, across the plugins.
Suggested change
| run: cargo install cargo-deny@0.19.8 --locked | |
| run: cargo install cargo-deny@0.20.2 --locked |
Contributor
Author
There was a problem hiding this comment.
Updated CI to cargo-deny 0.20.2 to match the README and the other plugins.
Update the affected HTTP, TLS, XML, and error-handling dependencies. Require patched Tokio versions for downstream consumers.
Check advisories, licenses, duplicate versions, and sources on pushes and pull requests. Document unavoidable GTK exceptions.
Contributor
Author
|
Squashed both follow-up commits into their original commits. The PR now contains two commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI currently does not check Rust dependencies for advisories or enforce license and source policies. Add a dedicated cargo-deny job on pushes and pull requests.
The policy checks all platforms and development dependencies, rejects wildcard dependencies and unapproved sources, and reports duplicate versions as warnings. Update affected dependencies, raise the Tokio minimum version, and document two upstream exceptions: proc-macro-error and glib in Tauri's GTK stack.
Closes #23