bugfix/BA-3301-fe-multiline-posts-is-showing-in-single-line#386
bugfix/BA-3301-fe-multiline-posts-is-showing-in-single-line#386davidbermudez-tsl wants to merge 1 commit into
Conversation
|
📝 WalkthroughWalkthroughPostForm replaces its plain-text ChangesContent Editor Field
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/components/modules/content-feed/web/PostForm/index.tsx (1)
45-49: 📐 Maintainability & Code Quality | ⚡ Quick winConsider explicit height configuration for consistent UX.
The previous
TextFieldhadrows={4}to control height. Consider addingminHeightor similar sizing props toMarkdownEditorFieldto maintain visual consistency with the original design.💡 Example configuration
<MarkdownEditorField name="content" placeholder="What is on your mind?" control={form.control} + minHeight={100} />🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/components/modules/content-feed/web/PostForm/index.tsx` around lines 45 - 49, The MarkdownEditorField in PostForm currently lacks an explicit height causing inconsistent UI compared to the previous TextField with rows={4}; update the MarkdownEditorField usage (name="content", control={form.control}) to include a sizing prop or style (e.g., minHeight, height, or a rows-equivalent) so the editor defaults to the original visual height (approx. 4 text rows) and preserves layout consistency across devices.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@packages/components/modules/content-feed/web/PostForm/index.tsx`:
- Around line 45-49: The MarkdownEditorField in PostForm currently lacks an
explicit height causing inconsistent UI compared to the previous TextField with
rows={4}; update the MarkdownEditorField usage (name="content",
control={form.control}) to include a sizing prop or style (e.g., minHeight,
height, or a rows-equivalent) so the editor defaults to the original visual
height (approx. 4 text rows) and preserves layout consistency across devices.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: a33a0e4f-58ac-4681-bf6b-de9a655afbf9
📒 Files selected for processing (1)
packages/components/modules/content-feed/web/PostForm/index.tsx



Wasn't able to reproduce bug, but added Markdown editor as @nossila recommended.
Summary by CodeRabbit