Handle server-prefixed AUTHENTICATE in SASL dispatcher#20
Merged
Conversation
The startup handler matched AUTHENTICATE on parts[0], ignoring lines carrying an RFC 1459 :prefix (e.g. Ergo's ':ergo.test AUTHENTICATE +'). When prefixed, the SASL handshake stalled until the caller's timeout tripped. Mirror the CAP/NOTICE pattern and read the payload argument from parts[2] when the command sits at parts[1]. Fixes #19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19.
Summary
startupHandlermatchedAUTHENTICATEonly onparts[0], so server-prefixed lines (e.g. Ergo's:ergo.test AUTHENTICATE +) were ignored and the SASL handshake stalled until the caller timed out.CAP/NOTICEpattern: match onparts[0]ornumeric(=parts[1]), and read the payload fromparts[2]when the line is prefixed.CAP,NOTICE, and numerics already handle prefixes correctly.Test plan