Replace deep-eql with node:assert.deepStrictEqual#18
Merged
Conversation
deep-eql v5 is pure ESM and can no longer be loaded via CommonJS require (throws 'equal is not a function'). Dropping the dependency in favour of Node's built-in assert.deepStrictEqual removes the CJS/ESM interop issue and eliminates a devDependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deep-eqlv5 is pure ESM, soconst equal = require("deep-eql")no longer returns a callable function from CommonJS, causingTypeError: equal is not a functionin the test suite (this is what blocked Renovate PR Update dependency deep-eql to v5 #6).assert(equal(a, b))call sites intest/irc-socket.jswith Node's built-inassert.deepStrictEqual(a, b)and removes thedeep-eqldevDependency entirely.Test plan
npm testpasses locally (47/47)