chore: fix underlying causes of playbook warnings - #290
Draft
Q-Dub wants to merge 1 commit into
Draft
Conversation
Q-Dub
marked this pull request as draft
July 31, 2026 11:33
pre
reviewed
Jul 31, 2026
pre
left a comment
Contributor
There was a problem hiding this comment.
Motivation for silencing the warnings and ignoring errors is not clear to me 🤔
Contributor
Author
|
To clarify: the scope is to resolve underlying issues which are triggering warnings, not to silence anything. |
Replace sudo preflight ignore_errors with block/rescue, skip modprobe when modules are already loaded, cast inotify sysctl value to string, remove duplicate cron service key, use kubectl create waits instead of retry loops, and document running exported playbooks from bloom-playbook/. Co-authored-by: Cursor <cursoragent@cursor.com>
Q-Dub
force-pushed
the
chore_playbook_warnings_cleanup
branch
from
August 5, 2026 06:19
b452689 to
9d6f1f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Ansible playbook warnings by addressing root causes, not suppressing them.
bloom-playbook/soansible.cfgloadsinventory.ini(export wiring already onmain)ignore_errors+ registered-result check withblock/rescue; fail immediately with actionable message when privilege escalation is unavailablemodprobewheniscsi_tcp/dm_modare already loaded (built-in or present under/sys/module)sysctlmoduleenabledYAML keykubectl wait --for=createbefore readiness checks instead of Ansible retry loops that emitFAILED - RETRYINGNon-goals / rejected approaches
warn: falseon RKE2curl | shinstall tasks — removed; unsupported on current Ansibleignore_errors: trueon sudo preflight — removed in favor of explicitblock/rescuefailureTest plan
./bloom cli bloom.yaml --export— confirminventory.iniandansible.cfgpresentcd bloom-playbook && ansible-playbook cluster-bloom.yaml— no inventory warningssudo ./bloom cli bloom.yaml— sudo preflight still fails clearly without passwordless sudodm_modis built-inFAILED - RETRYINGlines during namespace/deployment waits