Skip to content

chore: fix underlying causes of playbook warnings - #290

Draft
Q-Dub wants to merge 1 commit into
mainfrom
chore_playbook_warnings_cleanup
Draft

chore: fix underlying causes of playbook warnings#290
Q-Dub wants to merge 1 commit into
mainfrom
chore_playbook_warnings_cleanup

Conversation

@Q-Dub

@Q-Dub Q-Dub commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Summary

Fix Ansible playbook warnings by addressing root causes, not suppressing them.

  • Export inventory: Document running exported playbooks from bloom-playbook/ so ansible.cfg loads inventory.ini (export wiring already on main)
  • Sudo preflight: Replace ignore_errors + registered-result check with block/rescue; fail immediately with actionable message when privilege escalation is unavailable
  • Kernel modules: Skip modprobe when iscsi_tcp / dm_mod are already loaded (built-in or present under /sys/module)
  • Inotify sysctl: Pass string value to the sysctl module
  • Logrotate cron task: Remove duplicate enabled YAML key
  • Local-path waits: Use kubectl wait --for=create before readiness checks instead of Ansible retry loops that emit FAILED - RETRYING

Non-goals / rejected approaches

  • warn: false on RKE2 curl | sh install tasks — removed; unsupported on current Ansible
  • ignore_errors: true on sudo preflight — removed in favor of explicit block/rescue failure

Test plan

  • ./bloom cli bloom.yaml --export — confirm inventory.ini and ansible.cfg present
  • cd bloom-playbook && ansible-playbook cluster-bloom.yaml — no inventory warnings
  • sudo ./bloom cli bloom.yaml — sudo preflight still fails clearly without passwordless sudo
  • QEMU CI integration test passes
  • RKE2 prep: no modprobe warnings when dm_mod is built-in
  • Local-path deploy: no FAILED - RETRYING lines during namespace/deployment waits

@Q-Dub
Q-Dub requested a review from a team as a code owner July 31, 2026 10:13
@Q-Dub
Q-Dub marked this pull request as draft July 31, 2026 11:33

@pre pre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Motivation for silencing the warnings and ignoring errors is not clear to me 🤔

Comment thread pkg/ansible/runtime/playbooks/cluster-bloom.yaml Outdated
@Q-Dub

Q-Dub commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

To clarify: the scope is to resolve underlying issues which are triggering warnings, not to silence anything.

@Q-Dub Q-Dub changed the title chore: silence ansible playbook warnings chore: fix underlying causes of playbook warnings Aug 5, 2026
Replace sudo preflight ignore_errors with block/rescue, skip modprobe
when modules are already loaded, cast inotify sysctl value to string,
remove duplicate cron service key, use kubectl create waits instead of
retry loops, and document running exported playbooks from bloom-playbook/.

Co-authored-by: Cursor <cursoragent@cursor.com>
@Q-Dub
Q-Dub force-pushed the chore_playbook_warnings_cleanup branch from b452689 to 9d6f1f1 Compare August 5, 2026 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants