Skip to content

Update VS Code Launch config for new Serval architecture - #523

Merged
pmachapman merged 1 commit into
masterfrom
update_vscode_launch_config
Sep 29, 2026
Merged

pmachapman merged 1 commit into
masterfrom
update_vscode_launch_config

Conversation

@pmachapman

@pmachapman pmachapman commented Sep 28, 2026 •

Copy link
Copy Markdown
Collaborator

Updates the VS Code Launch Config to point to the new Serval docker image.


This change is Reviewable

@codecov-commenter

codecov-commenter commented Sep 28, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.34%. Comparing base (f2ca324) to head (d66b354).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #523   +/-   ##
=======================================
  Coverage   74.34%   74.34%           
=======================================
  Files         456      456           
  Lines       38261    38261           
  Branches     5242     5242           
=======================================
  Hits        28445    28445           
  Misses       8666     8666           
  Partials     1150     1150           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Enkidu93 Enkidu93 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Enkidu93 reviewed all commit messages and made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on pmachapman).


.vscode/launch.json line 10 at r1 (raw file):

            "request": "attach",
            "platform": "netCore",
            "processName": "Serval.ApiServer",

I don't this ought to be here anymore, right? This is a holdover from when the machine engine was in this repo.

@pmachapman
pmachapman requested a review from Enkidu93 September 28, 2026 18:17

@pmachapman pmachapman left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pmachapman made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on Enkidu93).


.vscode/launch.json line 10 at r1 (raw file):

I don't this ought to be here anymore, right? This is a holdover from when the machine engine was in this repo.

Could be. I only found this as I wanted to debug an issue with the machine library while Serval was running it.

An alternative to this PR would be to just delete this file, and add it to .gitignore so that developers can use their own launch configurations.

@Enkidu93 Enkidu93 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Enkidu93 made 2 comments and resolved 1 discussion.
Reviewable status: 0 of 1 files reviewed, all discussions resolved.


.vscode/launch.json line 10 at r1 (raw file):

Previously, pmachapman (Peter Chapman) wrote…

I don't this ought to be here anymore, right? This is a holdover from when the machine engine was in this repo.

Could be. I only found this as I wanted to debug an issue with the machine library while Serval was running it.

An alternative to this PR would be to just delete this file, and add it to .gitignore so that developers can use their own launch configurations.

Oh, I see, hmm. Are you not able to debug machine while launching the debugger in Serval? If this is what you need to do to make that work, then go for it.

@pmachapman
pmachapman requested a review from Enkidu93 September 28, 2026 22:50

@pmachapman pmachapman left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pmachapman made 1 comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on Enkidu93).


.vscode/launch.json line 10 at r1 (raw file):

Are you not able to debug machine while launching the debugger in Serval?

I could - The C# extension for VS code was playing up, so I tried connecting from the Machine project, which led to me discovering this. I ended up switching to using JetBrains Rider as its debugging tools are a lot easier to use for Docker.

@pmachapman
pmachapman requested a review from ddaspit September 28, 2026 22:50

@ddaspit ddaspit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ddaspit reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Enkidu93).

@pmachapman
pmachapman force-pushed the update_vscode_launch_config branch from 1d8e198 to d66b354 Compare September 29, 2026 18:07
@pmachapman
pmachapman merged commit c7146cd into master Sep 29, 2026
6 checks passed
@pmachapman
pmachapman deleted the update_vscode_launch_config branch September 29, 2026 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants