Update VS Code Launch config for new Serval architecture - #523
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #523 +/- ##
=======================================
Coverage 74.34% 74.34%
=======================================
Files 456 456
Lines 38261 38261
Branches 5242 5242
=======================================
Hits 28445 28445
Misses 8666 8666
Partials 1150 1150 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Enkidu93
left a comment
There was a problem hiding this comment.
@Enkidu93 reviewed all commit messages and made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on pmachapman).
.vscode/launch.json line 10 at r1 (raw file):
"request": "attach", "platform": "netCore", "processName": "Serval.ApiServer",
I don't this ought to be here anymore, right? This is a holdover from when the machine engine was in this repo.
pmachapman
left a comment
There was a problem hiding this comment.
@pmachapman made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on Enkidu93).
.vscode/launch.json line 10 at r1 (raw file):
I don't this ought to be here anymore, right? This is a holdover from when the machine engine was in this repo.
Could be. I only found this as I wanted to debug an issue with the machine library while Serval was running it.
An alternative to this PR would be to just delete this file, and add it to .gitignore so that developers can use their own launch configurations.
Enkidu93
left a comment
There was a problem hiding this comment.
@Enkidu93 made 2 comments and resolved 1 discussion.
Reviewable status: 0 of 1 files reviewed, all discussions resolved.
.vscode/launch.json line 10 at r1 (raw file):
Previously, pmachapman (Peter Chapman) wrote…
I don't this ought to be here anymore, right? This is a holdover from when the machine engine was in this repo.
Could be. I only found this as I wanted to debug an issue with the machine library while Serval was running it.
An alternative to this PR would be to just delete this file, and add it to
.gitignoreso that developers can use their own launch configurations.
Oh, I see, hmm. Are you not able to debug machine while launching the debugger in Serval? If this is what you need to do to make that work, then go for it.
pmachapman
left a comment
There was a problem hiding this comment.
@pmachapman made 1 comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on Enkidu93).
.vscode/launch.json line 10 at r1 (raw file):
Are you not able to debug machine while launching the debugger in Serval?
I could - The C# extension for VS code was playing up, so I tried connecting from the Machine project, which led to me discovering this. I ended up switching to using JetBrains Rider as its debugging tools are a lot easier to use for Docker.
ddaspit
left a comment
There was a problem hiding this comment.
@ddaspit reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on Enkidu93).
1d8e198 to
d66b354
Compare
Updates the VS Code Launch Config to point to the new Serval docker image.
This change is