Fix double mappings handling and expand trailing paragraph marker definition - #521
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #521 +/- ##
==========================================
+ Coverage 74.33% 74.34% +0.01%
==========================================
Files 456 456
Lines 38249 38261 +12
Branches 5237 5242 +5
==========================================
+ Hits 28432 28445 +13
Misses 8666 8666
+ Partials 1151 1150 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ddaspit
left a comment
There was a problem hiding this comment.
I pushed two fixes.
@ddaspit reviewed 2 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Enkidu93 and pmachapman).
tests/SIL.Machine.Tests/Corpora/ConvertUsfmVersificationHandlerTests.cs line 977 at r3 (raw file):
string[] targetLines = target.Split('\n'); string[] truthLines = truth.Split('\n'); // Assert.That(targetLines.Length, Is.EqualTo(truthLines.Length));
Nit: did you mean to comment this out?
pmachapman
left a comment
There was a problem hiding this comment.
This worked well for my test projects.
@pmachapman reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Enkidu93).
e69e44e to
9171d13
Compare
When a verse range started with a verse that was already written, the whole range marker was dropped, merging later verses into the previous one. Now only the duplicated verse is suppressed and the rest of the range is still written. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Preserved trailing paragraph markers collected before a verse that is not kept were flushed at the next kept verse, producing stray empty paragraphs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
9171d13 to
52463f3
Compare
Port sillsdev/machine#472 and the follow-up fixes from sillsdev/machine#521. ParatextProjectTextUpdaterBase.update_usfm now converts the source USFM to the rows' versification when it differs from the project's, using the new ConvertUsfmVersificationHandler. The test project settings now default to English versification, matching ScriptureRef, so existing update tests do not trigger a conversion. Closes #369 Closes #382 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Co-authored-by: Damien Daspit <3261883+ddaspit@users.noreply.github.com>
Port sillsdev/machine#472 and the follow-up fixes from sillsdev/machine#521. ParatextProjectTextUpdaterBase.update_usfm now converts the source USFM to the rows' versification when it differs from the project's, using the new ConvertUsfmVersificationHandler. The test project settings now default to English versification, matching ScriptureRef, so existing update tests do not trigger a conversion. Closes #369 Closes #382 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Co-authored-by: Damien Daspit <3261883+ddaspit@users.noreply.github.com>
Fixes #517, #518.
This change is